XPp ‘DOS’ Variable (XPp SP1)

Topic

New Reply

Slightly off post here, but can anyone see why this simple DOS script doesn’t work? It always evaluates to the variable “NO”. I should stick to VBA and JS, rather than this simple DOS stuff?!

TIA,

Ade

**************************
@ECHO OFF

SET /p userin=Are you connected to the network? Press Y for Yes, or N for No…

IF NOT “userin”==”Y” GOTO No
IF “userin”==”Y” GOTO Yes

:Yes
ECHO You answered Yes
GOTO End

:No
ECHO You answered No

:End
Pause
**************************

Reply | Quote

Replies

To refer to a variable, you must enclose it in % characters. “userin” is just a literal string.

IF NOT “%userin%”==”Y” GOTO No
IF “%userin%”==”Y” GOTO Yes

(the last line is actually superfluous in this version, but your batch file probably contains a lot more.)

Reply | Quote

Many thanks for that – knew the variable wasn’t being declared properly. Like I said, I should stick to VBA and JS…!

(and yes, there is a lot more to the script).

Thanks again,

Ade

Reply | Quote

Many thanks for that – knew the variable wasn’t being declared properly. Like I said, I should stick to VBA and JS…!

(and yes, there is a lot more to the script).

Thanks again,

Ade

Reply | Quote

To refer to a variable, you must enclose it in % characters. “userin” is just a literal string.

IF NOT “%userin%”==”Y” GOTO No
IF “%userin%”==”Y” GOTO Yes

(the last line is actually superfluous in this version, but your batch file probably contains a lot more.)

Reply | Quote

Ade,

I just noticed one potential “gotcha”, which may or may not be relevant to your usage:
if the user types “y” then this will be interpretted as NOT “Y”.
Perhaps the following logic might be safer:

IF “userin”==”y” GOTO Yes
IF “userin”==”Y” GOTO Yes
GO TO No

Reply | Quote

Yep, came across that about an hour ago…many thanks.

Reply | Quote

Yep, came across that about an hour ago…many thanks.

Reply | Quote

Ade,

I just noticed one potential “gotcha”, which may or may not be relevant to your usage:
if the user types “y” then this will be interpretted as NOT “Y”.
Perhaps the following logic might be safer:

IF “userin”==”y” GOTO Yes
IF “userin”==”Y” GOTO Yes
GO TO No

Reply | Quote